Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog: autofocus button does not get focus #6718

Closed
leevva opened this issue Jun 3, 2024 · 2 comments · Fixed by #6721 or leoo1992/GeradorQRCode#57 · May be fixed by nhattpn/BTL_LTNC#56
Closed

Dialog: autofocus button does not get focus #6718

leevva opened this issue Jun 3, 2024 · 2 comments · Fixed by #6721 or leoo1992/GeradorQRCode#57 · May be fixed by nhattpn/BTL_LTNC#56
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.7.0

Comments

@leevva
Copy link

leevva commented Jun 3, 2024 •
edited
Loading

Describe the bug

If there was a button with autofocus in the dialog, then when the dialog was opened the button received focus.
Since 10.6.4 it does not. Pressing Enter just closes dialog.
Therefore, you can no longer press Enter to press the button.

Reproducer

https://stackblitz.com/edit/vitejs-vite-rehwzq

PrimeReact version

10.6.6

React version

18.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@leevva leevva added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jun 3, 2024
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jun 3, 2024
@melloware
Copy link
Member

Might be related to this issue and fix: #6095

melloware added a commit to melloware/primereact that referenced this issue Jun 3, 2024
@melloware
Fix primefaces#6718: FocusTrap better handling of autoFocus property
79dc952
@melloware melloware mentioned this issue Jun 3, 2024
Merged
@melloware
Copy link
Member

OK PR submitted.

@melloware melloware self-assigned this Jun 3, 2024
@melloware melloware added this to the 10.7.0 milestone Jun 3, 2024
melloware added a commit that referenced this issue Jul 2, 2024
@melloware
Fix #6718: FocusTrap better handling of autoFocus property (#6721)
f5005c0
@nhattpn nhattpn mentioned this issue Jul 25, 2024
Open
@leoo1992 leoo1992 mentioned this issue Jul 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.7.0
2 participants
@melloware @leevva