Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

colorpicker: Color picker popup not closing on escape button click in some specific scenarios #6693

Closed
akshayaqburst opened this issue May 28, 2024 · 0 comments · Fixed by #6694, leoo1992/GeradorQRCode#57 or leoo1992/GeradorQRCode#80 · May be fixed by nhattpn/BTL_LTNC#56
Closed

colorpicker: Color picker popup not closing on escape button click in some specific scenarios #6693

akshayaqburst opened this issue May 28, 2024 · 0 comments · Fixed by #6694, leoo1992/GeradorQRCode#57 or leoo1992/GeradorQRCode#80 · May be fixed by nhattpn/BTL_LTNC#56
Assignees
@akshayaqburst
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.7.0

Comments

@akshayaqburst
Copy link
Contributor

Describe the bug

colorpicker: Color picker popup not closing on escape button click in some specific scenarios. See the repro steps for more details.

Reproducer

No response

PrimeReact version

10.6.6

React version

17.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

  1. Go to https://primereact.org/colorpicker/
  2. Click on the color picker icon in the basic color picker section, a popup appears.
  3. Click or drag up/down on the hue vertical bar on the right.
  4. Now press escape button.
  5. The color picker popup does not close.

Expected behavior

The color picker popup should close on escape button click.
@akshayaqburst akshayaqburst added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 28, 2024
akshayaqburst pushed a commit to qburst/primereact_qb_32 that referenced this issue May 28, 2024
fix: primefaces#6693, colorpicker: Color picker popup not closing on …
f0eded4 
…escape button click in some specific scenarios
@akshayaqburst akshayaqburst mentioned this issue May 28, 2024
Merged
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels May 28, 2024
@melloware melloware added this to the 10.7.0 milestone May 28, 2024
melloware pushed a commit that referenced this issue May 28, 2024
@akshayaqburst
fix: #6693, colorpicker: Color picker popup not closing on escape but…
b6a51c8 
…ton click in some specific scenarios (#6694)

Co-authored-by: ANTONA09 <akshay.antony@nyulangone.org>
@nhattpn nhattpn mentioned this issue Jul 25, 2024
Open
@leoo1992 leoo1992 mentioned this issue Jul 25, 2024
Merged
@leoo1992 leoo1992 mentioned this issue Aug 19, 2024
Merged
@hiterharris hiterharris mentioned this issue Aug 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akshayaqburst akshayaqburst

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.7.0
2 participants
@melloware @akshayaqburst