InputNumber throw error and not update the value when use browser autocomplete

[vnts7]

Describe the bug

InputNumber throw error and not update the value when use browser autocomplete to enter the value

Error:

TypeError: Cannot read properties of undefined (reading 'startsWith')
    at Object.onInputKeyDown [as onKeyDown] (inputnumber.esm.js:719:1)

Reproducer

https://stackblitz.com/edit/vitejs-vite-mnmoqt

PrimeReact version

10.6.6

React version

18.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

Chrome

Steps to reproduce the behavior

No response

Expected behavior

No response

[Rekl0w]

Can you check your stackblitz link ? I think it is not related with this issue.

[vnts7]

Can you check your stackblitz link ? I think it is not related with this issue.

Hi, in this demo, if you select any value from autocomplete list, you would see the "Current value" is not updated

[vnts7]

I've updated "primereact" to version "10.6.5", so you could the exception in the console too

[Rekl0w]

PR submitted.

[vnts7]

Hi,
I've tested again on version 10.6.6 and look like the issue is still there
The exception is gone but the value is still not being updated correctly

https://stackblitz.com/edit/vitejs-vite-mnmoqt

[melloware]

I have re-opened the ticket thanks for reporting @vnts7

[Fallup]

@vnts7 @melloware I think that it now behaves like it used to in previous major version - you have to use onValueChange for the browser autocomplete to work. It has been like this in the PrimeReact for a long time and for the InputNumber the onValueChange is a recommended callback to use as mentioned in the docs https://primereact.org/inputnumber/#numerals

onChange is primarily for the InputText or if you want to react to value changes in the InputNumber dynamically as user types but beware that this will interfere with the min/max props if you use them (the validation will be triggered after each keypress resulting in user not being able to change the value at all in some cases)

See https://stackblitz.com/edit/vitejs-vite-7jqdj7?file=src%2FApp.tsx

[melloware]

You rock @Fallup