Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable: FilterButton causes react warning in development <Invalid value for prop id on <div> tag> #6366

Closed
sandramfdeveloper opened this issue Apr 10, 2024 · 5 comments · Fixed by #6367 or leoo1992/GeradorQRCode#23
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@sandramfdeveloper
Copy link

sandramfdeveloper commented Apr 10, 2024

Describe the bug

In the FilterButton of the DataTable component (regardless of the filterDisplay you use), the following red warning occurs:

Warning: Invalid value for prop id on

tag. Either remove it from the element, or pass a string or number value to keep it in the DOM. For details, see https://reactjs.org/link/attribute-behavior

This can be verified by opening the developer mode in the stackblitz of the example itself (I have taken the advanced mode). When compiling in production, the error does not appear (I have checked this both on the documentation page and in the table of my project).

But it's annoying during development. It only appears the first time you click any of the filter buttons of the filters.

Reproducer

https://stackblitz.com/edit/qstla3?file=src%2FApp.jsx

PrimeReact version

10.6.3

React version

18.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

Chrome 123.0.6312.106

Steps to reproduce the behavior

  1. Open the Stackblitz link.
  2. Open developer mode.
  3. Click one of the table's filter buttons.

Expected behavior

No error appears, it's likely that an incorrect id is being passed.

@sandramfdeveloper sandramfdeveloper added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 10, 2024
@melloware
Copy link
Member

your stackblitz link goes to no whree...

@melloware melloware added Status: Needs Reproducer Issue needs a runnable reproducer and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Apr 10, 2024
Copy link

Please fork the Stackblitz project and create a case demonstrating your bug report. This issue will be closed if no activities in 20 days.

@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Reproducer Issue needs a runnable reproducer labels Apr 10, 2024
@melloware melloware self-assigned this Apr 10, 2024
@melloware melloware added this to the 10.6.4 milestone Apr 10, 2024
melloware added a commit to melloware/primereact that referenced this issue Apr 10, 2024
@melloware
Copy link
Member

Nevermind PR submitted!

melloware added a commit to melloware/primereact that referenced this issue Apr 10, 2024
@sandramfdeveloper
Copy link
Author

your stackblitz link goes to no whree...

My bad sorry, now it's working

@melloware
Copy link
Member

Yep I could actually reproduce it on the showcase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
2 participants