Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tree: Checkboxes use wrong color in the check mark. #6287

Closed
VentuzVictorPerez opened this issue Apr 2, 2024 · 0 comments · Fixed by #6295
Closed

Tree: Checkboxes use wrong color in the check mark. #6287

VentuzVictorPerez opened this issue Apr 2, 2024 · 0 comments · Fixed by #6295
Assignees
@nitrogenous @gucal
Labels
Type: Bug Issue contains a defect related to a specific component.

Comments

@VentuzVictorPerez
Copy link

VentuzVictorPerez commented Apr 2, 2024 •
edited
Loading

Describe the bug

Checkbox does not contain p-checkbox-icon classname which results in wrong color usage.

Reproducer

https://primereact.org/tree/#checkboxselection

PrimeReact version

10.6.2

React version

18.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

  1. Go to the reproducer.
  2. See in devtools how the classname p-checkbox-icon is not included in the SVG element:
    image

That results in the checkmark using the wrong color:

image

Other components (like Datatable) do have it:
image
image

Expected behavior

Checkbox must use the current color.
@VentuzVictorPerez VentuzVictorPerez added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 2, 2024
@VentuzVictorPerez VentuzVictorPerez mentioned this issue Apr 2, 2024
Closed
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Apr 3, 2024
gucal added a commit that referenced this issue Apr 3, 2024
@gucal
Fix #6287 - Tree: Checkboxes use wrong color in the check mark.
31b5a9a
@gucal gucal mentioned this issue Apr 3, 2024
Merged
nitrogenous added a commit that referenced this issue Apr 3, 2024
@nitrogenous
Merge pull request #6295 from primefaces/tree-checkbox
b03ec0f 
Fix #6287 - Tree: Checkboxes use wrong color in the check mark.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nitrogenous nitrogenous

@gucal gucal

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #6287 - Tree: Checkboxes use wrong color in the check mark. primefaces/primereact
4 participants
@melloware @nitrogenous @gucal @VentuzVictorPerez