Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: Support for Quill 2.0.0 #5960

Closed
melloware opened this issue Feb 14, 2024 · 6 comments · Fixed by #6429 or leoo1992/GeradorQRCode#23
Closed

Editor: Support for Quill 2.0.0 #5960

melloware opened this issue Feb 14, 2024 · 6 comments · Fixed by #6429 or leoo1992/GeradorQRCode#23
Assignees
@melloware
Labels
dependencies Issue or pull request is related to a dependency package javascript Pull requests that update Javascript code Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
10.6.4

Comments

@melloware
Copy link
Member

Discussed in https://github.com/orgs/primefaces/discussions/1182

Originally posted by jbkly February 12, 2024
The PrimeReact Editor depends on Quill v1.3.7, which was last updated in 2019, relies on deprecated browser events, and exposes a cross-site scripting vulnerability.

The past 2 months have seen active development on Quill 2.0.0. There is now a release candidate, updated documentation and migration guide to v2, and a stable 2.0.0 release planned for March 1.

Are there plans to update PrimeReact's dependency on Quill to the new version?
@melloware melloware transferred this issue from primefaces/community Feb 14, 2024
@melloware melloware added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add javascript Pull requests that update Javascript code labels Feb 14, 2024
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 14, 2024
@melloware melloware added dependencies Issue or pull request is related to a dependency package and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Feb 14, 2024
@melloware melloware added this to the 11.0.0 milestone Feb 14, 2024
@Renrhaf
Copy link

Renrhaf commented Mar 8, 2024

+1 for this update

1 similar comment
@9vitorconti
Copy link

+1 for this update

@melloware
Copy link
Member Author

Yep once Quill 2.0 goes final.

@adgoncal adgoncal mentioned this issue Mar 27, 2024
Closed
@melloware melloware mentioned this issue Apr 6, 2024
Closed
@jbkly
Copy link

jbkly commented Apr 19, 2024

Quill 2.0 is now released: https://github.com/quilljs/quill/releases/tag/v2.0.0

@melloware
Copy link
Member Author

It only took Quill 5 years... 😄

melloware added a commit to melloware/primereact that referenced this issue Apr 20, 2024
@melloware
Fix primefaces#5960: Quill 2.0.0 support
0080f57
@melloware melloware self-assigned this Apr 20, 2024
@melloware melloware mentioned this issue Apr 20, 2024
Merged
@melloware
Copy link
Member Author

OK PR submitted. Seems like everything is working well.

melloware added a commit to melloware/primereact that referenced this issue Apr 20, 2024
@melloware
Fix primefaces#5960: Quill 2.0.0 support
763d692
melloware added a commit to melloware/primereact that referenced this issue Apr 20, 2024
@melloware
Fix primefaces#5960: Quill 2.0.0 support
d78cd05
melloware added a commit to melloware/primereact that referenced this issue Apr 21, 2024
@melloware
Fix primefaces#5960: Quill 2.0.0 support
0ae5805
@FeBe95 FeBe95 mentioned this issue Apr 25, 2024
Open
nitrogenous added a commit that referenced this issue Apr 29, 2024
@nitrogenous
Merge pull request #6429 from melloware/PR5960-editor
689cdf6 
Fix #5960: Quill 2.0.0 support
@melloware melloware modified the milestones: 11.0.0, 10.6.4 May 3, 2024
@leoo1992 leoo1992 mentioned this issue May 21, 2024
Merged
@melloware melloware mentioned this issue Aug 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
dependencies Issue or pull request is related to a dependency package javascript Pull requests that update Javascript code Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
10.6.4
4 participants
@Renrhaf @melloware @jbkly @9vitorconti