Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accordion (Tailwind): Cannot read properties of undefined (reading 'disabled') #5804

Closed
tobiasgeezee opened this issue Jan 19, 2024 · 6 comments · Fixed by #5807, #6549, leoo1992/GeradorQRCode#27, leoo1992/GeradorQRCode#40 or mtech-31-quemistry/quemistry_client_web#3
Closed

Accordion (Tailwind): Cannot read properties of undefined (reading 'disabled') #5804

tobiasgeezee opened this issue Jan 19, 2024 · 6 comments · Fixed by #5807, #6549, leoo1992/GeradorQRCode#27, leoo1992/GeradorQRCode#40 or mtech-31-quemistry/quemistry_client_web#3
Assignees
@melloware
Labels
Component: Tailwind Tailwind specific issue
Milestone
10.6.5

Comments

@tobiasgeezee
Copy link
Contributor

Describe the bug

When using the Accordion with Primereact Provider and Tailwind theme from "import Tailwind from "primereact/passthrough/tailwind"" the Accortion crashed with the error: Cannot read properties of undefined (reading 'disabled')

Reproducer

https://codesandbox.io/p/sandbox/primereact-bug-template-tailwind-accordion-psdqj2

PrimeReact version

10.3.3

React version

18.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

  1. Add a PrimereactProvider with unstyled=true and pt=Tailwind (from import Tailwind from "primereact/passthrough/tailwind)
  2. add a accordion

Expected behavior

Accordion gets rendered without crash
@tobiasgeezee tobiasgeezee added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 19, 2024
@melloware melloware added Component: Tailwind Tailwind specific issue and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 19, 2024
@melloware melloware added this to the 10.4.0 milestone Jan 19, 2024
@melloware melloware self-assigned this Jan 19, 2024
@melloware
Copy link
Member

Thanks for reporting!

melloware added a commit to melloware/primereact that referenced this issue Jan 19, 2024
@melloware
Fix primefaces#5804: Accordion Tailwind disabled prop
2864245
@melloware melloware mentioned this issue Jan 19, 2024
Merged
melloware added a commit that referenced this issue Jan 19, 2024
@melloware
Fix #5804: Accordion Tailwind disabled prop (#5807)
a99cb2f
@dg-robinson
Copy link

This issue has re-appeared in v10.6.4 but worked correctly in the previous version. Removing the Tailwind theme also gets rid of the error.

@melloware
Copy link
Member

@dg-robinson see this ticket #6389 and PR #6390

@melloware
Copy link
Member

@dg-robinson i see the issue

melloware added a commit to melloware/primereact that referenced this issue May 2, 2024
@melloware
Fix primefaces#5804: AccordionTab PT error
a6d8956
@melloware melloware reopened this May 2, 2024
@melloware melloware modified the milestones: 10.4.0, 10.7.0 May 2, 2024
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 2, 2024
@melloware melloware mentioned this issue May 2, 2024
Merged
melloware added a commit to melloware/primereact that referenced this issue May 2, 2024
@melloware
Fix primefaces#5804: AccordionTab PT error
96bf828
melloware added a commit that referenced this issue May 2, 2024
@melloware
Fix #5804: AccordionTab PT error (#6549)
b777591
@melloware melloware removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 2, 2024
@melloware
Copy link
Member

10.6.5 is out can you try it and report back please?

@dg-robinson
Copy link

That's fixed it! Thanks so much.

@leoo1992 leoo1992 mentioned this issue May 24, 2024
Merged
@leoo1992 leoo1992 mentioned this issue Jun 14, 2024
Merged
@raymondhtet raymondhtet mentioned this issue Jun 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Component: Tailwind Tailwind specific issue
Projects
None yet
Milestone
10.6.5
3 participants
@dg-robinson @melloware @tobiasgeezee