Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PanelMenu:Items not displaying correctly #5777

Closed
MatteoCapu opened this issue Jan 16, 2024 · 1 comment · Fixed by #5779
Closed

PanelMenu:Items not displaying correctly #5777

MatteoCapu opened this issue Jan 16, 2024 · 1 comment · Fixed by #5779
Assignees
@melloware
Labels
React 18 Issue or pull request is *only* related to React 18 Type: Bug Issue contains a defect related to a specific component.
Milestone
10.3.2

Comments

@MatteoCapu
Copy link

Describe the bug

When using PanelMenu the items inside dont display at all,you can see it on your site as well.
primeerror

Reproducer

https://primereact.org/panelmenu/

PrimeReact version

10.3.1

React version

18.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

1.Open the PanelMenu page on the PrimeReact site
2.scroll down to the Basic example
3.open the panelmenu example

Expected behavior

The PanelMenu should display the items correctly
@MatteoCapu MatteoCapu added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 16, 2024
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 16, 2024
melloware added a commit to melloware/primereact that referenced this issue Jan 16, 2024
@melloware
Fix primefaces#5777: PanelMenu fix when strictmode = false
40afd56
@melloware melloware self-assigned this Jan 16, 2024
@melloware melloware added this to the 10.4.0 milestone Jan 16, 2024
@melloware melloware mentioned this issue Jan 16, 2024
Merged
@melloware melloware added the React 18 Issue or pull request is *only* related to React 18 label Jan 16, 2024
@melloware
Copy link
Member

Looks like it was only working in StrictMode=true but in Production Mode was not working. Fixed for next release.

melloware added a commit that referenced this issue Jan 16, 2024
@melloware
Fix #5777: PanelMenu fix when strictmode = false (#5779)
4e9f6ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
React 18 Issue or pull request is *only* related to React 18 Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.3.2
Development

Successfully merging a pull request may close this issue.

Fix #5777: PanelMenu fix when strictmode = false melloware/primereact
2 participants
@melloware @MatteoCapu