Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CascadeSelect: onInputKeyDown error in unstyled model #5424

Closed
kl-nevermore opened this issue Nov 28, 2023 · 1 comment · Fixed by #5430
Closed

CascadeSelect: onInputKeyDown error in unstyled model #5424

kl-nevermore opened this issue Nov 28, 2023 · 1 comment · Fixed by #5430
Assignees
@kl-nevermore
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.3.0

Comments

@kl-nevermore
Copy link
Contributor

kl-nevermore commented Nov 28, 2023 •
edited
Loading

Describe the bug

image

primereact/components/lib/cascadeselect/CascadeSelect.js

Line 145 in e135dc2

DomHandler.findSingle(overlayRef.current, '.p-cascadeselect-item').children[0].focus();

Reproducer

https://stackblitz.com/run?file=src%2FApp.js

PrimeReact version

latest

React version

17.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

Expected behavior

Maybe use

DomHandler.findSingle(overlayRef.current, '[data-pc-section="item"]').children[0].focus();

No response
@kl-nevermore kl-nevermore added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 28, 2023
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 28, 2023
melloware added a commit to melloware/primereact that referenced this issue Nov 28, 2023
@melloware
Fix primefaces#5424: CascadeSelect use data instead of CSS selector
bf4cf1a
@melloware melloware added this to the 10.2.2 milestone Nov 28, 2023
@melloware melloware mentioned this issue Nov 28, 2023
Merged
@melloware
Copy link
Member

Your suggestion works great! PR submitted.

melloware added a commit that referenced this issue Nov 28, 2023
@melloware
Fix #5424: CascadeSelect use data instead of CSS selector (#5430)
482a2dd
@melloware melloware modified the milestones: 10.2.2, 10.3.0 Nov 29, 2023
melloware added a commit to melloware/primereact that referenced this issue Jan 9, 2024
@melloware
Fix primefaces#5424: CascadeSelect use data instead of CSS selector
ba5addb
melloware added a commit that referenced this issue Jan 9, 2024
@melloware
Port fixes3 (#5711)
8c95949 
* Fix #5384: TreeTable support hidden columns

* fix:#5553:TreeTable: need to be converted to data- lookups instead of className lookups

* TreeTable

* Fix #5597: TreeTable body align

* Fix #5393: Tree propagate icons to leaf nodes

* Fix #5233: Cell editor ColumnEditorOptions param fix

* Fix #5398: Slider with min value rendered incorrectly

* Fix #5340: MutliSelect emptyMessage don't add to DOM

* Fix #4190: Chip aria fixes

* Fix #5414: p-disabled for svg icons

* Fix #5424: CascadeSelect use data instead of CSS selector

* Fix #5425: CascadeSelect fix for StrictMode

* Fix #5440: InputText only print className once
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kl-nevermore kl-nevermore

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.3.0
Development

Successfully merging a pull request may close this issue.

Fix #5424: CascadeSelect use data instead of CSS selector melloware/primereact
2 participants
@melloware @kl-nevermore