Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing icons #5333

Closed
inad9300 opened this issue Nov 16, 2023 · 1 comment · Fixed by #5336
Closed

Missing icons #5333

inad9300 opened this issue Nov 16, 2023 · 1 comment · Fixed by #5336
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.1.0

Comments

@inad9300
Copy link
Contributor

inad9300 commented Nov 16, 2023 •
edited
Loading

Describe the bug

As I tried telling you in #5179, there are many more icons listed in https://primereact.org/icons than entries in PrimeIcons.js.

I remembered again today when I noticed the absence of both the calculator and the wrench icons...

Reproducer

No response

PrimeReact version

9.6.2

React version

17.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@inad9300 inad9300 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 16, 2023
@melloware
Copy link
Member

Feel free to submit a PR.

@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 16, 2023
@melloware melloware added this to the 10.0.10 milestone Nov 16, 2023
@melloware melloware assigned melloware and unassigned inad9300 Nov 16, 2023
melloware added a commit to melloware/primereact that referenced this issue Nov 16, 2023
@melloware
Fix primefaces#5333: Missing PrimeIcons
d8de305
@melloware melloware mentioned this issue Nov 16, 2023
Merged
melloware added a commit that referenced this issue Nov 16, 2023
@melloware
Fix #5333: Missing PrimeIcons (#5336)
2b722df
kl-nevermore pushed a commit to Realmerit-UEX/primereact that referenced this issue Nov 17, 2023
@melloware @kl-nevermore
Fix primefaces#5333: Missing PrimeIcons (primefaces#5336)
ce5e787
@inad9300 inad9300 mentioned this issue Apr 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.1.0
Development

Successfully merging a pull request may close this issue.

Fix #5333: Missing PrimeIcons melloware/primereact
2 participants
@inad9300 @melloware