Toast/Messages: remove not working

[rpiaggio]

Describe the bug

Support to remove specific toast messages was added in #3457.

However, this doesn't seem to work. A peek at the implementation seems to identify the shown message by the _pId property, which is inaccesible by the client code.

Reproducer

https://codesandbox.io/s/primereact-test-forked-bbns8k?file=/src/index.js

PrimeReact version

10.0.3

React version

17.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

1. Call toastRef.current.show(msg).
2. Call toastRef.current.remove(msg).
3. Toast is not removed.

Expected behavior

Toast is removed.

[rpiaggio]

Messages may suffer from the same issue.

[melloware]

@rpiaggio have you debugged for a potential solution?

[rpiaggio]

One possible solution is to make the show and replace methods return the indexed objects created by assignIdentifiers. It seems if one of those objects are passed to remove, it would work.

[melloware]

yeah this is tricky. I know the clear method works to remove all messages but I am assuming you are targeting a specific message to remove.

[rpiaggio]

Yes, that's the case.

[melloware]

i will take a look and see if I can fix it.

[melloware]

Check out my PR. I check for either ID equality or if you pass a message like you are message equality of the JSON object.

[rpiaggio]

This seems like it should work, thank you! I'll eagerly await for the release.

[melloware]

i tested it locally and its working so crossing my fingers! Keep your eye out for a 10.0.4 release and let me know how it goes.

[melloware]

OK 10.0.4 is out if you want to test this fix.