Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConfirmPopup: Escape key does not close the popup. #4952

Closed
akshayaqburst opened this issue Sep 24, 2023 · 0 comments · Fixed by #4953
Closed

ConfirmPopup: Escape key does not close the popup. #4952

akshayaqburst opened this issue Sep 24, 2023 · 0 comments · Fixed by #4953
Assignees
@akshayaqburst
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
10.0.0

Comments

@akshayaqburst
Copy link
Contributor

Describe the bug

ConfirmPopup: Escape key does not close the popup.

Reproducer

No response

PrimeReact version

9.6.2

React version

17.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

  1. Click on confirm popup from sidebar.
  2. Click on confirm on Delete button, a popup comes.
  3. Click on Escape button, popup does not close.

Expected behavior

Popup should close on escape button click
@akshayaqburst akshayaqburst added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 24, 2023
akshayantony55 added a commit to qburst/primereact_qb_6 that referenced this issue Sep 24, 2023
@akshayantony55
fix Primefaces primefaces#4952 ConfirmPopup: Escape key does not clos…
1162d72 
…e the popup.
@akshayaqburst akshayaqburst mentioned this issue Sep 24, 2023
Merged
@melloware melloware added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 24, 2023
@melloware melloware added this to the 10.0.0 milestone Sep 24, 2023
@melloware melloware linked a pull request Sep 24, 2023 that will close this issue
fix Primefaces #4952 ConfirmPopup: Escape key does not close the popup. #4953
Merged
akshayantony55 added a commit to qburst/primereact_qb_6 that referenced this issue Sep 25, 2023
@akshayantony55
fix Primefaces primefaces#4952 ConfirmPopup: Escape key does not clos…
de16a5b 
…e the popup
melloware pushed a commit that referenced this issue Sep 25, 2023
@akshayaqburst
fix Primefaces #4952 ConfirmPopup: Escape key does not close the popu…
5669e57 
…p. (#4953)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akshayaqburst akshayaqburst

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
10.0.0
Development

Successfully merging a pull request may close this issue.

fix Primefaces #4952 ConfirmPopup: Escape key does not close the popup. qburst/primereact_qb_6
2 participants
@melloware @akshayaqburst