-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SplitButton: pt attribute doesn't behave as described in documentation #4883
Comments
@dominikj111 so the wireframe is the only thing wrong correct? |
The most easy fix would by to swap 2 and 3 in the wireframe. So I suppose I can give you positive answer @melloware, from that point of view. But from my perspective, the wireframe is correct but in table row the icon (2) needs to swap with the the button (3). For me the most confusing thing are the labels. Both items are buttons, but one is marked as icon and both accepts different passthrough type. |
OK let me assign this to PrimeTek. |
Docs have been updated: https://primereact.org/splitbutton/ |
Describe the bug
SplitButton wireframe shows that number 2 and 3 are labeled as icon and button and it doesn't match the options table.
So the
colours the opposite sections.
Also the passed pt structure is quite inconsistent. I'm wondering if there is any purpose for this.
Reproducer
https://codesandbox.io/s/primereact-demo-forked-dkrktv?file=/src/App.js
PrimeReact version
9.6.2
React version
18.x
Language
TypeScript
Build / Runtime
Create React App (CRA)
Browser(s)
No response
Steps to reproduce the behavior
No response
Expected behavior
No response
The text was updated successfully, but these errors were encountered: