Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: ResolveFieldData Performance Improvement #4797

Closed
melloware opened this issue Aug 18, 2023 · 0 comments · Fixed by #4798 or #4800
Closed

Core: ResolveFieldData Performance Improvement #4797

melloware opened this issue Aug 18, 2023 · 0 comments · Fixed by #4798 or #4800
Assignees
@melloware
Labels
Type: Performance Issue is performance or optimization related
Milestone
10.0.0

Comments

@melloware
Copy link
Member

Original Report: primefaces/primevue#4296

The resolveFieldData utility currently uses Object.keys as its first check before trying to return data. The call to Object.keys can get quite expensive and result in bad performance. This shows when its called for a large data set for a large number of components.

image
@melloware melloware self-assigned this Aug 18, 2023
@melloware melloware added the Type: Performance Issue is performance or optimization related label Aug 18, 2023
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 18, 2023
@melloware melloware added this to the 10.0.0 milestone Aug 18, 2023
melloware added a commit to melloware/primereact that referenced this issue Aug 18, 2023
@melloware
Fix primefaces#4797: ObjectUtils.resolveFieldData perf improvement
7173ff8
@melloware melloware mentioned this issue Aug 18, 2023
Merged
melloware added a commit to melloware/primereact that referenced this issue Aug 18, 2023
@melloware
Fix primefaces#4797: ObjectUtils.resolveFieldData perf improvement
c8fbf83
@melloware melloware removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 18, 2023
melloware added a commit that referenced this issue Aug 18, 2023
@melloware
Fix #4797: ObjectUtils.resolveFieldData perf improvement (#4798)
15b0368
melloware added a commit to melloware/primereact that referenced this issue Aug 18, 2023
@melloware
Fix primefaces#4797: ObjectUtils.resolveFieldData perf improvement
c61ae8d
@melloware melloware mentioned this issue Aug 18, 2023
Merged
melloware added a commit that referenced this issue Aug 19, 2023
@melloware
Fix #4797: ObjectUtils.resolveFieldData perf improvement (#4800)
48723c1
@melloware melloware modified the milestones: 10.0.0, 9.7.0 Aug 22, 2023
@melloware melloware modified the milestones: 9.7.0, 10.0.0 Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Performance Issue is performance or optimization related
Projects
None yet
Milestone
10.0.0
1 participant
@melloware