Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skeleton: children prop not rendering #4512

Closed
pratheeshpradeepkumars opened this issue Jun 15, 2023 · 2 comments · Fixed by #4515
Closed

Skeleton: children prop not rendering #4512

pratheeshpradeepkumars opened this issue Jun 15, 2023 · 2 comments · Fixed by #4515
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
9.6.0

Comments

@pratheeshpradeepkumars
Copy link

pratheeshpradeepkumars commented Jun 15, 2023 •
edited
Loading

Describe the bug

Skeleton with child component not rendering in UI. Up to 9.0.0-beta.1 version it's supported.
In documentation the children property is also mentioned
image

Reproducer

https://codesandbox.io/s/primereact-demo-forked-q96k4z

PrimeReact version

9.5.0

React version

18.x

Language

ES6

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@pratheeshpradeepkumars pratheeshpradeepkumars added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jun 15, 2023
melloware added a commit to melloware/primereact that referenced this issue Jun 15, 2023
@melloware
Fix primefaces#4512: Skeleton allow children
e09ea93
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jun 15, 2023
@melloware melloware self-assigned this Jun 15, 2023
@melloware melloware added this to the 9.6.0 milestone Jun 15, 2023
@melloware melloware mentioned this issue Jun 15, 2023
Merged
melloware added a commit that referenced this issue Jun 15, 2023
@melloware
Fix #4512: Skeleton allow children (#4515)
64803d3
@pratheeshpradeepkumars
Copy link
Author

@melloware Thank you

@melloware
Copy link
Member

No problem thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
9.6.0
Development

Successfully merging a pull request may close this issue.

Fix #4512: Skeleton allow children melloware/primereact
2 participants
@melloware @pratheeshpradeepkumars