-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dialog: Performing "onMouseDown" inside the Dialog and "onMouseUp" outside of it closes the dialog when "dismissableMask" is true #3962
Comments
Thanks for the reproducer its interesting I can make it happen with Create React App but not with Next. I have a fix that will work for both. |
Is there a possibility to release this fix in a minor version of 9.x.x instead of waiting until 10? Thanks (Sorry, I inadvertently closed and reopened the issue) |
its OK I have assigned PrimeTek to review my PR. |
Cool, thanks |
Hi @melloware , just to clarify, are we waiting for their response on the pull request you made in January, or did you re-request it after my question last week? |
Yep PrimeTek was working on major changes like today's 9.3.0 release allowing custom icons everywhere. So they have not been merging PR's |
But I have a feeling that they are only going to look at PR's that correspond to milestone 9.x.x, this issue is tagged with Milestone 10.0.0, hence my original question.
|
@VentuzVictor if you need this fixed sooner I suggest you investigate PRO support: https://primereact.org/support/ |
Cool, thanks! |
Describe the bug
Having "dismissableMask" as "true" in a Dialog, it closes automatically when an "onMouseDown" is performed inside the Dialog, for example selecting text inside an InputNumber / p and then releasing the mouse ("onMouseUp") outside the Dialog.
This causes bad user interaction and assuming that the Dialog contains a Form with several components, editing the InputNumber quickly and selecting the text inside causes it to close unexpectedly (see gif).
Reproducer
https://codesandbox.io/s/primereact-test-forked-uym2ut?file=/src/index.js:750-765
PrimeReact version
8.7.3
React version
18.x
Language
TypeScript
Build / Runtime
Create React App (CRA)
Browser(s)
Chrome 108
Steps to reproduce the behavior
-- It closes unexpectadly --.
Expected behavior
The dialog should remain displayed since officially an "onClick" was not performed outside of it ("onMouseDown" was performed inside and "onMouseUp" was performed outside).
The text was updated successfully, but these errors were encountered: