Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARIA: Lint Failures #2819

Closed
3 tasks done
melloware opened this issue Apr 29, 2022 · 0 comments · Fixed by #2825
Closed
3 tasks done

ARIA: Lint Failures #2819

melloware opened this issue Apr 29, 2022 · 0 comments · Fixed by #2825
Assignees
@cagataycivici @melloware @mertsincan
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Type: Bug Issue contains a defect related to a specific component.
Milestone
8.1.0

Comments

@melloware
Copy link
Member

melloware commented Apr 29, 2022 •
edited
Loading

Describe the bug

  • ./components/lib/autocomplete/AutoComplete.js

498:21 Warning: Elements with the ARIA role "combobox" must have the following attributes defined: aria-controls,aria-expanded jsx-a11y/role-has-required-aria-props

  • ./components/lib/multistatecheckbox/MultiStateCheckbox.js

124:21 Warning: Elements with the ARIA role "checkbox" must have the following attributes defined: aria-checked jsx-a11y/role-has-required-aria-props

  • ./components/lib/tristatecheckbox/TriStateCheckbox.js

73:21 Warning: Elements with the ARIA role "checkbox" must have the following attributes defined: aria-checked jsx-a11y/role-has-required-aria-props

Reproducer

Just run npm run lint

PrimeReact version

8.0.1

React version

18.x

Language

ALL

Build / Runtime

Next.js

Browser(s)

ALL

Steps to reproduce the behavior

Just run npm run lint

Expected behavior

No lint failures
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. Component: Accessibility Issue or pull request is related to WCAG or ARIA labels Apr 29, 2022
@melloware melloware added this to the 8.1.0 milestone Apr 29, 2022
@melloware melloware changed the title ARIA Lint Failures ARIA: Lint Failures Apr 29, 2022
melloware added a commit to melloware/primereact that referenced this issue Apr 30, 2022
@melloware
Fix primefaces#2819: Checkbox aria-checked
61dc5b4
@melloware melloware mentioned this issue Apr 30, 2022
Merged
melloware added a commit to melloware/primereact that referenced this issue Apr 30, 2022
@melloware
Fix primefaces#2819: Checkbox aria-checked
0272ac9
melloware added a commit that referenced this issue Apr 30, 2022
@melloware
Fix #2819: Checkbox aria-checked (#2825)
3f7edcb
@melloware melloware self-assigned this Apr 30, 2022
melloware added a commit that referenced this issue Apr 30, 2022
@melloware
Fix #2819: Checkbox aria-checked
3429cd7
@mertsincan mertsincan modified the milestones: 8.1.0, 8.1 May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagataycivici cagataycivici

@melloware melloware

@mertsincan mertsincan

Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
8.1.0
Development

Successfully merging a pull request may close this issue.

Fix #2819: Checkbox aria-checked melloware/primereact
3 participants
@cagataycivici @melloware @mertsincan