Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Sidebar component #2233

Closed
VsevolodGolovanov opened this issue Aug 5, 2021 · 1 comment
Closed

Improve Sidebar component #2233

VsevolodGolovanov opened this issue Aug 5, 2021 · 1 comment
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@VsevolodGolovanov
Copy link

VsevolodGolovanov commented Aug 5, 2021

I'm submitting a ... (check one with "x")

[x] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Codesandbox Case (Bug Reports)
https://codesandbox.io/s/sidebar-over-a-part-of-ui-8vrv1

Current behavior
Sidebar allows appending it to something and styling, so that it would show over a part of UI, not the whole page. But the mask gets appended to body anyway, blocking the "main menu" and sidebar itself.

Expected behavior
Click the button. See sidebar modaility blocking the "main menu" and sidebar itself.

Minimal reproduction of the problem with instructions

Please tell us about your environment:

  • React version:
  • PrimeReact version:
    6.5.0

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

  • Language: [all | TypeScript X.X | ES6/7 | ES5]
@VsevolodGolovanov
Copy link
Author

VsevolodGolovanov commented Aug 5, 2021

Sidenote: the modality overlay is a separate element - it should have its own className property. Or maybe be it should wrap the sidebar itself, like Dialog does?

@mertsincan mertsincan changed the title Sidebar's modality overlay should respect appendTo too Improve Sidebar component Nov 8, 2021
@mertsincan mertsincan self-assigned this Nov 8, 2021
@mertsincan mertsincan added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Nov 8, 2021
@mertsincan mertsincan added this to the 7.0.0.Final milestone Nov 8, 2021
mertsincan added a commit that referenced this issue Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

2 participants