πΈ improve: νλ‘ν νΈμ§ νμ΄μ§ μ€νμΌλ§ λ° κΈ°λ₯ κ°μ #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limkhl
requested review from
grighth12,
manudeli and
Parkserim
as code owners
grighth12
reviewed
Dec 17, 2021
src/components/base/Avatar/index.tsx
Outdated
Comment on lines
57
to
61
| {isEdit ? ( | ||
| <Filter> | ||
| <span>+</span> | ||
| </Filter> | ||
| ) : null} |
There was a problem hiding this comment.
base μ»΄ν¬λνΈμ μμΉνλ©΄ μ λκ³ , μ¬μ©νλ κ³³μμλ§ wrapperλ‘ κ°μΈμ€μΌ ν κ² κ°μλ° μΌλ¨μ λμ΄κ° λ΄ μλ€~~
There was a problem hiding this comment.
ν ... μμ μ’ κ·Έλ μ£ ? γ γ 리ν©ν λ§ν λ μμ νκ² μ΅λλ€ γ γ
src/components/base/Button/index.tsx
Outdated
Comment on lines
70
to
74
| & { | ||
| background-color: ${theme.colors.white}; | ||
| color: ${theme.colors.gray900}; | ||
| border: 1px solid ${theme.colors.gray200}; | ||
| } |
There was a problem hiding this comment.
& { } μ΄ μμ΄λ λ κ² κ°λ€μ!
There was a problem hiding this comment.
& { }κ° μμΌλ©΄ border μ€νμΌμ΄ μ λ¨ΉλλΌκ³ μ! λ€μ μλ border: none μ€νμΌμ λ¨Ήνλ κ² κ°μμ!
|
ν.. μ’ λ§μ΄ μ΄μλ°μ€..?! |
|
μ μΆκ°μ μΌλ‘ validation νλ €λ©΄ κΈμμλ₯Ό λμ΄κ°λ©΄ μμ μ λ ₯μ΄ λμ§ μκ² νλκ² μ’ λ μ’μ§ μμκΉ μΆμ΄μ! |
manudeli
force-pushed
the
refactor/user_edit/style
branch
from
583c543 to
5abedb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π μ€λͺ
νλ‘ν νΈμ§ νμ΄μ§ μ€νμΌλ§ λ° κΈ°λ₯ κ°μ
π μ°κ²°λ μ΄μ
closes #85
π¨ PR ν¬μΈνΈ
πΈ μ€ν¬λ¦° μ·