Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ refactor: 공유, 채팅, 즐겨찾기, 지도 버튼 domain 공통 컴포넌트로 분리 #91

Merged
merged 3 commits into from
Dec 16, 2021

Conversation

grighth12
Copy link
Member

@grighth12 grighth12 commented Dec 16, 2021

💁 설명

  • 버튼 컴포넌트들을 Domain 폴더 밑에 만들었습니다.
  • <CourtItem.Header ... /> <CourtItem.FavoriteToggle /> 과 같은 형태로 사용할 수 있습니다.

🔗 연결된 이슈

closes

🚨 PR 포인트

  • 버튼에 별도의 이벤트 핸들러 없이 정의된 props만 잘 넘기면 잘 작동되도록 만들어 놓았습니다!

📸 스크린 샷

Screen Shot 2021-12-16 at 9 17 22 PM

Screen Shot 2021-12-16 at 11 40 26 PM
2.png)

Screen Shot 2021-12-16 at 11 40 56 PM

@grighth12 grighth12 force-pushed the refactor/common/courts-action-buttons branch from 7bcee9d to 85977a4 Compare December 16, 2021 12:25
- address 컴포넌트 분리, date 컴포넌트 추가
@grighth12
Copy link
Member Author

@Parkserim 확인하시고 즐겨찾기, 예약 페이지 마무리 해주세용~!😊

@grighth12
Copy link
Member Author

다음 작업을 위해 선머지합니다!

@grighth12 grighth12 merged commit 24f78b9 into develop Dec 16, 2021
@grighth12 grighth12 deleted the refactor/common/courts-action-buttons branch December 16, 2021 15:14
@Parkserim
Copy link
Collaborator

@Parkserim 확인하시고 즐겨찾기, 예약 페이지 마무리 해주세용~!😊

넵 확인했습니다 감사합니다 굿굿👍❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants