Merge pull request #175 from prezly/feature/qrf-9-error-with-dynamic-…

…hrefs-on-search-page [QRF-9] Error with dynamic hrefs on search page
prezly · Aug 19, 2022 · d0972f5 · d0972f5 · vercel · Aug 19, 2022
2 parents fa60bdc + 78e14ba
commit d0972f5
Showing 1 changed file with 9 additions and 3 deletions.
diff --git a/modules/Search/components/Hit.tsx b/modules/Search/components/Hit.tsx
@@ -22,9 +22,15 @@ function HitComponent({ hit }: Props) {
     const { categories } = story;
     const { showDate, showSubtitle } = useThemeSettings();
 
+    // strip query params from story links
+    const storyLink = {
+        pathname: '/[slug]',
+        query: { slug: story.slug },
+    };
+
     return (
         <div className={classNames(cardStyles.container, cardStyles.small)}>
-            <Link href={`/${story.slug}`} locale={false} passHref>
+            <Link href={storyLink} locale={false} passHref>
                 <a className={cardStyles.imageWrapper}>
                     <StoryImage
                         story={story}
@@ -41,7 +47,7 @@ function HitComponent({ hit }: Props) {
                     </div>
                 )}
                 <h3 className={classNames(cardStyles.title, cardStyles.titleSmaller)}>
-                    <Link href={`/${story.slug}`} locale={false} passHref>
+                    <Link href={storyLink} locale={false} passHref>
                         <a className={classNames(cardStyles.titleLink, styles.title)}>
                             <Highlight hit={hit} attribute="attributes.title" tagName="mark" />
                         </a>
@@ -50,7 +56,7 @@ function HitComponent({ hit }: Props) {
 
                 {showSubtitle && (
                     <p className={cardStyles.subtitle}>
-                        <Link href={`/${story.slug}`} locale={false} passHref>
+                        <Link href={storyLink} locale={false} passHref>
                             <a className={cardStyles.titleLink}>{story.subtitle}</a>
                         </Link>
                     </p>