-
Notifications
You must be signed in to change notification settings - Fork 2
[QRF-33] Fix contact card links layout #192
[QRF-33] Fix contact card links layout #192
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add screenshots of story contacts on different screens, or add some contacts to a story, so that the changes can be tested visually :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix for the links looks good to me, but I was thinking that the original issue was about Contact cards in stories. Probably better to tackle the issue in a separate PR (since it probably requires some design input from what I see)
@oleg-semyonov As suggested by @iamhugofelix and @alpower in the linear issue, we should use the same contact cards on the whole project I believe? This fix also applies to contact cards in the stories, you can visit one here: At the very bottom of the page I have added a contact card in story. |
@oleg-semyonov @mohammadxali Just for my learning, do these CSS change only apply to the web view of a story? i.e. they don't affect how a contact is laid out in email for example? |
@alpower I believe they only applied to theme, and emails use a different styling mechanism |
tablet-up
instead oftablet-only
to have the same layout for contact cards in desktop and tabletoverflow-wrap: break-word;
to make sure links are always visible according to thisflex-wrap: wrap;
to ensure links can go to next line if they don't fit on a single lineOnce you approve, I will port these changes to Bea