Skip to content
This repository has been archived by the owner on Jul 17, 2024. It is now read-only.

[QRF-33] Fix contact card links layout #192

Merged

Conversation

mohammadxali
Copy link
Contributor

@mohammadxali mohammadxali commented Aug 17, 2022

  • Use tablet-up instead of tablet-only to have the same layout for contact cards in desktop and tablet
  • Use overflow-wrap: break-word; to make sure links are always visible according to this
  • Use flex-wrap: wrap; to ensure links can go to next line if they don't fit on a single line

Once you approve, I will port these changes to Bea

@mohammadxali mohammadxali added the bug Something isn't working label Aug 17, 2022
@mohammadxali mohammadxali requested a review from riffbyte August 17, 2022 13:15
@mohammadxali mohammadxali self-assigned this Aug 17, 2022
@vercel
Copy link

vercel bot commented Aug 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
theme-nextjs-greta-preview ✅ Ready (Inspect) Visit Preview Aug 18, 2022 at 8:15AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
theme-nextjs-greta-cookbook ⬜️ Ignored (Inspect) Aug 18, 2022 at 8:15AM (UTC)
theme-nextjs-greta-photography ⬜️ Ignored (Inspect) Aug 18, 2022 at 8:15AM (UTC)
theme-nextjs-greta-the-good-newsroom ⬜️ Ignored (Inspect) Aug 18, 2022 at 8:15AM (UTC)

Copy link
Contributor

@riffbyte riffbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add screenshots of story contacts on different screens, or add some contacts to a story, so that the changes can be tested visually :)

@mohammadxali
Copy link
Contributor Author

Greta Contacts - Mobile
Greta Contacts - Desktop
Greta Contacts - Tablet

@oleg-semyonov Updated with screenshots

@mohammadxali mohammadxali requested a review from riffbyte August 18, 2022 08:19
Copy link
Contributor

@riffbyte riffbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix for the links looks good to me, but I was thinking that the original issue was about Contact cards in stories. Probably better to tackle the issue in a separate PR (since it probably requires some design input from what I see)

@mohammadxali
Copy link
Contributor Author

mohammadxali commented Aug 19, 2022

@oleg-semyonov As suggested by @iamhugofelix and @alpower in the linear issue, we should use the same contact cards on the whole project I believe? This fix also applies to contact cards in the stories, you can visit one here:
https://theme-nextjs-greta-preview-git-feature-qrf-33-be-be03d8-prezly1.vercel.app/this-is-a-test-story

At the very bottom of the page I have added a contact card in story.

@mohammadxali mohammadxali merged commit 117003b into main Aug 19, 2022
@mohammadxali mohammadxali deleted the feature/qrf-33-bea-greta-the-contact-block-in-the-story branch August 19, 2022 04:53
@alpower
Copy link

alpower commented Aug 19, 2022

@oleg-semyonov @mohammadxali Just for my learning, do these CSS change only apply to the web view of a story? i.e. they don't affect how a contact is laid out in email for example?

@mohammadxali
Copy link
Contributor Author

@alpower I believe they only applied to theme, and emails use a different styling mechanism

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants