Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MT-5280] Feature - Implement banner on preview newsrooms #308

Merged
merged 8 commits into from
Aug 11, 2022

Conversation

e1himself
Copy link
Contributor

@e1himself e1himself commented Aug 8, 2022

@e1himself e1himself self-assigned this Aug 8, 2022
@vercel
Copy link

vercel bot commented Aug 8, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
theme-nextjs-bea-preview ✅ Ready (Inspect) Visit Preview Aug 11, 2022 at 10:11AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
theme-nextjs-bea-cookbook ⬜️ Ignored (Inspect) Aug 11, 2022 at 10:11AM (UTC)
theme-nextjs-bea-photography ⬜️ Ignored (Inspect) Aug 11, 2022 at 10:11AM (UTC)
theme-nextjs-bea-the-good-newsroom ⬜️ Ignored (Inspect) Aug 11, 2022 at 10:11AM (UTC)

@e1himself e1himself requested review from riffbyte and kudlajz August 8, 2022 15:28
@lgtm-com
Copy link

lgtm-com bot commented Aug 8, 2022

This pull request introduces 1 alert when merging 8d0cbf1 into 6b5c51b - view on LGTM.com

new alerts:

  • 1 for Potentially unsafe external link

Copy link
Contributor

@riffbyte riffbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some remarks, also please note the TSC and ESLint complaints :)

modules/Layout/Notifications.tsx Outdated Show resolved Hide resolved
@e1himself e1himself changed the base branch from main to feature/tf-637-setup-i18n-testing-environment August 11, 2022 10:07
@e1himself e1himself changed the base branch from feature/tf-637-setup-i18n-testing-environment to main August 11, 2022 10:07
@e1himself e1himself merged commit ee83109 into main Aug 11, 2022
@e1himself e1himself deleted the feature/mt-5280-implement-banner-on-preview-newsrooms branch August 11, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants