[DEV-13254] Implement settings menu for variables with optional fallback #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e1himself
reviewed
Aug 6, 2024
packages/slate-editor/src/extensions/variables/VariableElement.module.scss
Outdated
Show resolved
Hide resolved
e1himself
approved these changes
Aug 6, 2024
….module.scss Thanks @e1himself Co-authored-by: Ivan Voskoboinyk <ivan@prezly.com>
kudlajz
deleted the
feature/dev-13254-implement-settings-menu-for-variable-node
branch
e1himself
reviewed
Aug 7, 2024
| @@ -5,6 +5,7 @@ export const VARIABLE_NODE_TYPE = 'variable'; | |||
|
|
|||
| export interface VariableNode extends ElementNode { | |||
| type: typeof VARIABLE_NODE_TYPE; | |||
| fallback?: string | null; | |||
There was a problem hiding this comment.
@kudlajz by the way, Slate does not allow null as a node property value. Setting a property to null with Transforms.setNodes() will remove it from the object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
%something%but instead use the label for better claritywithFallback: truecan have a text fallback set for themI still have to run this with the UX people so the UI might change.
Default:
With fallback defined:
Choosing different options:
