Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEV-18547] Feature - Support ESLint v9 #13

Merged
merged 45 commits into from
Dec 25, 2024
Merged

[DEV-18547] Feature - Support ESLint v9 #13

merged 45 commits into from
Dec 25, 2024

Conversation

mohammadxali
Copy link
Contributor

@mohammadxali mohammadxali commented Nov 19, 2024 •
edited
Loading

  • Switch to Pnpm
  • Support ESLint v9 (BC: Breaking Change)
  • Added tests

@mohammadxali mohammadxali self-assigned this Nov 19, 2024
@mohammadxali mohammadxali changed the title [DEV-18547] Feature - Flat-ify configurations to support ESLint v9 [DEV-18547] Feature - Support ESLint v9 Nov 19, 2024
@mohammadxali mohammadxali force-pushed the feature/dev-18547-upgrade-prezlycode-style-to-support-eslint-v9 branch from 6dd9242 to 88d0001 Compare November 19, 2024 10:34
@mohammadxali
Setup test script
0df2dae
@mohammadxali
Upgrade all packages to their latest version
c38cdee
@mohammadxali
Revert test script
c25330b
@mohammadxali
5.4.6-0
457b540
@mohammadxali
Pass env via languageOptions.globals
acf173e
@mohammadxali
Upgrade peerDependency eslint version to v9
337ac60
@mohammadxali
5.4.6-1
e50f5c5
@mohammadxali
Convert all require() syntax to import
f1a6669
@mohammadxali
Add type: "module" to root package.json file
6cc4d0b
@mohammadxali
5.4.6-2
82e284f
@mohammadxali
Use default export for all rule-config utils
6504369
@mohammadxali
5.4.6-3
b34d13c
@mohammadxali
Add export default to rest of eslint configs
25dd087
@mohammadxali
5.4.6-4
d425192
@mohammadxali
Use import() syntax for plugins as well
24bd409
@mohammadxali
5.4.6-5
bef597d
@mohammadxali
Move ecmaFeatures to parserOptions for v9
2c47c67
@mohammadxali
5.4.6-6
d4bd1f6
@mohammadxali
Install v9 compatible eslint packages
519593c
@mohammadxali
Rework the configuration files to support the new config
7c869f9
@mohammadxali
Setup a playground testing project to test config
0164fef
@mohammadxali
5.4.6-7
bbf6589
@mohammadxali
Fix react-hooks plugin throwing
bd2d71e
fgyimah
fgyimah approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@fgyimah fgyimah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏾

e1himself
e1himself approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@e1himself e1himself left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything tricky or dangerous here. This is just a version upgrade, right?

Great job, Ali! 👍

@mohammadxali
Copy link
Contributor Author

This is just a version upgrade, right?

Right! :) A major version update.

@mohammadxali mohammadxali merged commit 0f49380 into main Dec 25, 2024
4 checks passed
@mohammadxali mohammadxali deleted the feature/dev-18547-upgrade-prezlycode-style-to-support-eslint-v9 branch December 25, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e1himself e1himself e1himself approved these changes

@fgyimah fgyimah fgyimah approved these changes

@kudlajz kudlajz Awaiting requested review from kudlajz

@yuriyyakym yuriyyakym Awaiting requested review from yuriyyakym

Assignees

@mohammadxali mohammadxali

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohammadxali @e1himself @fgyimah