Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV-12735] Replace current events with new ones using more generic naming #294

Merged

Conversation

kudlajz
Copy link
Contributor

@kudlajz kudlajz commented Apr 4, 2024

We want to expose these events to our users in Plausible, so we need better/more generic event names.

@kudlajz kudlajz requested a review from alpower April 4, 2024 09:55
@kudlajz kudlajz self-assigned this Apr 4, 2024
export const STORY_IMAGE = {
CLICK: 'Story Image Click',
DOWNLOAD: 'Story Image Download',
VIEW: 'Story Image View',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alpower Previously we've also tracked when image/gallery image was "opened" in stories. Not sure if we need this in Plausible? 🤔

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it hurt to leave it in? I can see this being nice to know, if not now, at some point.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean.. I guess we could keep it, just seems a bit useless to track that if we're not gonna show it in the dashboard.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's not costing us anything to track it I say keep it, as quite what we show in the dashboard is still up in the air a bit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Custom events count as pageviews - we have 10 M events per month and we're already at 0,5 M and it's the 4th day of the month, so in theory it should be okay, but who knows, depends on the amount of images visitors are viewing.

Also, even if we add the Goals to the dashboard later, it won't show past data so I'd say let's skip it for now and I can add it later if we decide that we want this information there, otherwise let's not waste the event limit.

Sounds good?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah sounds good - if it counts towards limits then I agree.

@kudlajz kudlajz requested a review from marko-ogg April 4, 2024 10:10
@kudlajz kudlajz merged commit 67fc34b into main Apr 4, 2024
7 checks passed
@kudlajz kudlajz deleted the feature/dev-12735-implement-plausible-events-in-bea-theme branch April 4, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants