Make google configuration consistent

prezly · Jan 29, 2025 · 25943f3 · 25943f3
1 parent 3fc08d6
commit 25943f3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/packages/analytics-nextjs/src/Analytics.ts b/packages/analytics-nextjs/src/Analytics.ts
@@ -94,9 +94,9 @@ export class Analytics {
         }
 
         if (config.google) {
+            const { analyticsId } = config.google;
             import('./lib/loadGoogleAnalytics').then(({ loadGoogleAnalytics }) => {
-                // @ts-ignore
-                loadGoogleAnalytics(config.google.analyticsId);
+                loadGoogleAnalytics(analyticsId);
             });
         }
 
@@ -147,9 +147,9 @@ export class Analytics {
 
         this.consent = consent;
 
-        const googleAnalyticsId = this.config?.google?.analyticsId;
-        if (googleAnalyticsId) {
-            window[`ga-disable-${googleAnalyticsId}`] = this.permissions.canTrackToGoogle;
+        if (this.config?.google) {
+            const { analyticsId } = this.config.google;
+            window[`ga-disable-${analyticsId}`] = this.permissions.canTrackToGoogle;
         }
 
         this.promises.segmentInit?.then(() => {

diff --git a/packages/analytics-nextjs/src/types.ts b/packages/analytics-nextjs/src/types.ts
@@ -53,9 +53,11 @@ export interface TrackingPermissions {
 export interface Config {
     consent?: Consent;
     trackingPolicy: TrackingPolicy;
-    google?: {
-        analyticsId: string;
-    };
+    google?:
+        | false
+        | {
+              analyticsId: string;
+          };
     plausible?: false | PlausibleOptions;
     segment:
         | false