Document RuboCop's Style/Lambda should be disabled #816
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
Style/Lambda
cop from RuboCop has a chance on conflicting with the way@prettier/plugin-ruby
wants to format code.Say we have this original code:
After prettifying, the code will turn to this:
However, RuboCop does not like this, and would prefer multiline lambdas to instead look like this:
But if I did that change, then after prettier run, the code would turn to this one:
which
Style/Lambda
cop would then complain that the code should be like this instead:...but if I did that, then we'd be back at this code after prettier run:
So in the end, what we decided to do was disable
Style/Lambda
for the Ruby files that are formatted with Prettier. I figured it would be worth it to document this cop needs to be disabled in order not to cause conflicts between RuboCop and@prettier/plugin-ruby
.