Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ugly Sorbet formatting #863

Closed
4 of 5 tasks
azz opened this issue Apr 12, 2021 · 0 comments · Fixed by #912
Closed
4 of 5 tasks

Ugly Sorbet formatting #863

azz opened this issue Apr 12, 2021 · 0 comments · Fixed by #912
Milestone

Comments

@azz
Copy link
Member

azz commented Apr 12, 2021

Metadata

  • Ruby version: ruby 2.7.2p137 (2020-10-01 revision 5445e04352) [x86_64-darwin19]
  • @prettier/plugin-ruby or prettier gem version: 1.5.2
  • Options:
    • rubyHashLabel
    • rubyModifier
    • rubySingleQuote
    • rubyToProc
    • trailingComma

Input

sig { params(contacts: Contact::ActiveRecord_Relation).returns(Customer::ActiveRecord_Relation) }

Current output

sig do
  params(contacts: Contact::ActiveRecord_Relation).returns(
    Customer::ActiveRecord_Relation,
  )
end

Expected output

sig do
  params(contacts: Contact::ActiveRecord_Relation)
    .returns(Customer::ActiveRecord_Relation)
end

Not really sure what the best output is, but it look a bit weird right now.

@kddnewton kddnewton added this to the v2.0.0 milestone May 12, 2021
kddnewton added a commit that referenced this issue Jun 23, 2021
@kddnewton kddnewton mentioned this issue Jun 23, 2021
kddnewton pushed a commit that referenced this issue Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants