-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow "none" as an option for attributeSeparator #116
Allow "none" as an option for attributeSeparator #116
Conversation
d70b260
to
0d9873a
Compare
0d9873a
to
dd7df8e
Compare
I need to investigate why the checks / tests are not running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- You should add a test case were attributes starting with
:
and@
are on a wrapped own line - You should add an extra pug-file test that contains e.g.
(click)
(angular syntax) as a non first attribute
If this tests break with an exception, you should expect this in the tests AND add a warning note for users in theREADME.md
Can you try to just use |
Oh yes, sorry about the force-pushes! I will work on this again tomorrow. |
@Shinigami92 this should be good to go now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I need to work on my .github/workflows/ci.yml
so the checks will be triggered
Will let you know when you need to merge master
into this branch (or maybe I can do this with a button click)
Edit: ok no button for me 🙁, so you need to merge the master branch into yours
That includes a CI change and updated dependencies (so also the outdated check will not fail)
I'm trying to do so, but am dealing with this strange error currently: git push
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
To https://github.com/lehni/plugin-pug
! [remote rejected] master -> master (refusing to allow an OAuth App to create or update workflow `.github/workflows/ci.yml` without `workflow` scope) |
The weird part is that I'm not actually using OAuth, I'm using the command line directly? |
But |
I had to switch from using
|
@Shinigami92 I finally managed to merge master into this, should go all green shortly 🤞 |
Closes #102