Skip to content

fix(transform): correct chained optional expression with computed properties #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2020
Merged

fix(transform): correct chained optional expression with computed properties #193

merged 1 commit into from
May 9, 2020

Conversation

ikatyang
Copy link
Member

@ikatyang ikatyang commented May 9, 2020

Fixes #191

input

a ?. b [ c ]
a ?. b () [ c ]

before

{ type: "MemberExpression" }
{ type: "MemberExpression" }

after

{ type: "OptionalMemberExpression" }
{ type: "OptionalMemberExpression" }

@codecov

This comment has been minimized.

Sign in to view
@ikatyang ikatyang merged commit 73cf46d into master May 9, 2020
@ikatyang ikatyang deleted the fix/transform/keyed-read-with-optional-obj branch May 9, 2020 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

a?.b[c] is parsed incorrectly
1 participant
@ikatyang