Separate connection clone objects from normal objects #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tacking on the changes made in pret/pokeemerald#1755 |
GriffinRichards
force-pushed
the
clone-union
branch
from
26570d9 to
bfd1fb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a union to
ObjectEventTemplatefor accessing fields used differently by "connection clones", a type of object event that stores the local id and map of an object from a connecting map to mirror. The JSON data was also updated to reflect that there are two types of object events.This is a breaking change for Porymap, do not merge until a new version is released that supports this.