Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build System Rewrite] Sorted and cleaned up graphics_file_rules.mk #1956

Closed
wants to merge 2 commits into from

Conversation

Icedude907
Copy link
Contributor

@Icedude907 Icedude907 commented Nov 14, 2023

Description

Rewrote most of graphics_file_rules.mk and sorted rules alphabetically. Some dead code has been removed.
Includes a destinction between input and output directories (although they are the same for the moment).

The motivation behind this is to make the file easier to browse and parse for newcomers.

Discord contact info

icedude907

@Icedude907 Icedude907 marked this pull request as ready for review November 23, 2023 22:36
@GriffinRichards
Copy link
Member

Aside from adding comments I'm not sure this is worth it if we're not going to merge the later changes that make use of the distinction between input/output directories. With a few exceptions this file is largely populated with rules that should be ignored by downstream users (because they're just for matching) so I don't think we need to worry that much about sorting the entries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants