Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the links on the doc page for the 0.291 release #24661

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dnskr
Copy link
Contributor

@dnskr dnskr commented Mar 2, 2025

Description

Fix the incorrect links on the 0.291 release page:

  1. The upgrade notes of lucene-core, lucene-queryparser and lucene-analyzer-common should have the same link to WS-2021-0646. Actually, changed link https://vuln.whitesourcesoftware.com/vulnerability/WS-2021-0646 redirects to https://www.mend.io/vulnerability-database/WS-2021-0646 page.
  2. The upgrade note of hibernate-validator has link with incorrect PR number (24168 instead of 24177).

Motivation and Context

Fix incorrect links and resolve the following warnings:

./presto/presto-docs/src/main/sphinx/release/release-0.291.rst:3: WARNING: Duplicate explicit target name: "ws-2021-0646".
./presto/presto-docs/src/main/sphinx/release/release-0.291.rst:3: WARNING: Duplicate explicit target name: "ws-2021-0646".
./presto/presto-docs/src/main/sphinx/release/release-0.291.rst:3: WARNING: Duplicate explicit target name: "#24168".

Impact

None

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@dnskr dnskr requested review from steveburnett, elharo and a team as code owners March 2, 2025 20:15
@dnskr dnskr requested a review from jaystarshot March 2, 2025 20:15
@github-actions github-actions bot added the docs label Mar 2, 2025
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull branch, local doc build, looks good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants