Add session property for jdbc metadata, pool size, caching enabled #23843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konjac-h
force-pushed
the
improve-xdb-caching-controability
branch
from
7e4d71a
to
832e065
Compare
Co-authored-by: Steve Burnett <burnett@pobox.com>
Co-authored-by: Steve Burnett <burnett@pobox.com>
Co-authored-by: Steve Burnett <burnett@pobox.com>
As part of new native plan checker SPI, the new property eager-plan-validation-enabled will enable the eager building and validation of a logical plan so that any errors or incompatibilities in the plan will cause the query to fail quickly, before queueing and cluster resources are assigned to keep queries with invalid plans from holding slots in the queue. RFC: https://github.com/prestodb/rfcs/blob/main/RFC-0008-plan-checker.md
This adds a new SPI to support plugin custom plan checkers to be provided for validating intermediate, final, and fragment stages of a logical plan. The motivation for this is to allow for a native plan checker that will eagerly validate a plan on the native sidecar to quickly fail the query if there are incompatibilities. Add unit test to verify that a queued query can be validated and fail while queued. This is done by using the new custom plan checker SPI to add plugin that will trigger a failure when validating the plan. See also: prestodb#23596 RFC: https://github.com/prestodb/rfcs/blob/main/RFC-0008-plan-checker.md
Adds a new counter `presto_cpp.memory_pushback_reduction_bytes` that keeps track of the actual used memory reduction for every memory pushback attempt.
Update the `ResourceGroupView` component to properly display a subgroup which is in 3rd or more level. Signed-off-by: Yihong Wang <yh.wang@ibm.com>
konjac-h
force-pushed
the
improve-xdb-caching-controability
branch
from
832e065
to
798f31b
Compare
konjac-h
requested review from
elharo,
yhwang,
hantangwangd,
ZacBlanco,
shrinidhijoshi,
a team,
jaystarshot,
feilong-liu and
ClarenceThreepwood
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request enables the control of JDBC in-memory metadata caching through the use of a session property. Additionally, it also provides the capability to manage the thread pool size.
Motivation and Context
Currently, Presto does not have the capability to control the JDBC metadata thread pool size and caching for certain sources. This pull request aims to address this limitation by making these features available in Presto.
Impact
as above
Test Plan
build & deploy to verifier that the change will be picked up by inspecting session property at query level
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.