[test] Fix flaky test TestQueues.testEagerPlanValidation #23841
Merged
+3
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The TestQueues.testEagerPlanValidation is meant to trigger a plan validation failure in an async thread, but a race condition can occur if the query is created and the validation thread manages to complete before the trigger is set. Moving the trigger to be set before the query is created will ensure that it fails during validation.
Motivation and Context
Flaky test TestQueues.testEagerPlanValidation reported in #23838
Impact
Test Plan
Manually stopped main thread to simulate load and verified the race condition was fixed by moving the trigger.
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.