Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Fix flaky test TestQueues.testEagerPlanValidation #23841

Merged

Conversation

BryanCutler
Copy link
Contributor

@BryanCutler BryanCutler commented Oct 16, 2024

Description

The TestQueues.testEagerPlanValidation is meant to trigger a plan validation failure in an async thread, but a race condition can occur if the query is created and the validation thread manages to complete before the trigger is set. Moving the trigger to be set before the query is created will ensure that it fails during validation.

Motivation and Context

Flaky test TestQueues.testEagerPlanValidation reported in #23838

Impact

Test Plan

Manually stopped main thread to simulate load and verified the race condition was fixed by moving the trigger.

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

@tdcmeehan tdcmeehan merged commit 90742a4 into prestodb:master Oct 16, 2024
56 checks passed
@BryanCutler BryanCutler deleted the eager-plan-validiation-test-fix branch October 16, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants