Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Iceberg]Enable test cases for rename table on REST and NESSIE catalog #23837

Conversation

hantangwangd
Copy link
Member

@hantangwangd hantangwangd commented Oct 15, 2024

Description

We have already supported rename table on Iceberg connector configured with REST and NESSIE catalog. This PR enable existing test cases for rename table on them.

In PR #16612, we introduced IcebergNativeMetadata, since then, the catalogs integrated into presto Iceberg connector based on IcebergNativeMetadata can support rename table functionality if they originally support this functionality in Iceberg library. This means REST and NESSIE catalog has already supported the rename table functionality, so we can enable existing test cases for rename table on them directly.

Motivation and Context

Increase the coverage of code testing

Impact

N/A

Test Plan

N/A

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@hantangwangd hantangwangd marked this pull request as ready for review October 15, 2024 18:01
@hantangwangd hantangwangd requested review from ZacBlanco and a team as code owners October 15, 2024 18:01
@tdcmeehan tdcmeehan self-assigned this Oct 15, 2024
@ZacBlanco
Copy link
Contributor

Can you link the PR/commit which enabled renames in the PR description?

@hantangwangd
Copy link
Member Author

Can you link the PR/commit which enabled renames in the PR description?

Sure, the link and relevant description have been added.

@hantangwangd hantangwangd merged commit f1058cc into prestodb:master Oct 16, 2024
57 checks passed
@hantangwangd hantangwangd deleted the enable_rename_table_test_for_rest_nessie branch October 16, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants