Prepend jdbc: to DatabaseMetaData.getURL result #23397
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the PrestoDatabaseMetaData implementation of the getURL method to
include the jdbc: prefix in the resulting URL. A JDBC URL always starts with
jdbc:.
Added an unit and a product test to verify that the database connection URL
starts with the expected jdbc: prefix.
Description
Append the jdbc: prefix to the URL that is returned from the
PrestoDatabaseMetaData implementation of the getURL method.
Motivation and Context
A JDBC URL return from the getURL method of the
DatabaseMetaData interface provides a way of identifying a
database so that the appropriate driver recognizes it and
connects to it. A JDBC URL always starts with jdbc: which was
lacking in the current PrestoDatabaseMetaData implementation
of the getURL method.
#19312
Impact
Callers of the method PrestoDatabaseMetaData.getURL will be
able to use the resulting URL directly without having to prepend
the jdbc: prefix themselves.
Test Plan
Added a unit test in the TestPrestoDatabaseMetaData class and
a product test in JdbcTests class that asserts the URL starts with t
the jdbc: prefix and the rest of the URL did not change.
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.