-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a new CoordinatorPlugin interface for native clusters #23144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdabre12
force-pushed
the
plugin-V2
branch
2 times, most recently
from
July 19, 2024 20:33
aee0740
to
8fb4ba4
Compare
pdabre12
changed the title
[WIP] Introduce a new pluginV2 interface for native clusters
[WIP] Introduce a new CoordinatorPlugin interface for native clusters
Jul 19, 2024
tdcmeehan
requested changes
Jul 26, 2024
pdabre12
force-pushed
the
plugin-V2
branch
2 times, most recently
from
July 29, 2024 20:23
72ec801
to
0159601
Compare
pdabre12
requested review from
jaystarshot,
feilong-liu,
elharo,
ClarenceThreepwood and
a team
as code owners
July 29, 2024 20:37
pdabre12
changed the title
[WIP] Introduce a new CoordinatorPlugin interface for native clusters
Introduce a new CoordinatorPlugin interface for native clusters
Jul 29, 2024
elharo
reviewed
Jul 29, 2024
presto-tests/src/main/java/com/facebook/presto/tests/DistributedQueryRunner.java
Show resolved
Hide resolved
tdcmeehan
previously approved these changes
Jul 31, 2024
tdcmeehan
reviewed
Jul 31, 2024
pdabre12
force-pushed
the
plugin-V2
branch
2 times, most recently
from
August 1, 2024 17:26
008ff16
to
21f8042
Compare
tdcmeehan
requested changes
Aug 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tiny nit, otherwise LGTM
presto-spi/src/main/java/com/facebook/presto/spi/CoordinatorPlugin.java
Outdated
Show resolved
Hide resolved
tdcmeehan
approved these changes
Aug 1, 2024
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce a new CoordinatorPlugin interface for native clusters.
Test Plan
Unit tests
Resolves : #23297