[native] Implement bucket conversion for Hive splits #23028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
presto-native-execution/presto_cpp/main/types/PrestoToVeloxConnector.cpp
Show resolved
Hide resolved
presto-native-execution/presto_cpp/main/types/PrestoToVeloxConnector.cpp
Show resolved
Hide resolved
There was a problem hiding this comment.
Thanks @Yuhta. Overall looks very good minus some documentation comments.
|
@Yuhta : We should have a Release note for this PR I feel. Please can you add details in the PR description. |
xiaoxmeng
previously approved these changes
Jun 18, 2024
presto-native-execution/presto_cpp/main/types/PrestoToVeloxConnector.cpp
Outdated
Show resolved
Hide resolved
presto-native-execution/presto_cpp/main/types/PrestoToVeloxConnector.cpp
Show resolved
Hide resolved
presto-native-execution/presto_cpp/main/types/PrestoToVeloxConnector.cpp
Outdated
Show resolved
Hide resolved
presto-native-execution/presto_cpp/main/types/tests/PrestoToVeloxSplitTest.cpp
Outdated
Show resolved
Hide resolved
Yuhta
force-pushed
the
tasks/T192188366/0
branch
from
e083aa8
to
5150948
Compare
When the bucket count of a table changes over time, there can be legitimate cases that multiple buckets exist in the same file. In such cases the query planner should set bucket conversion for these splits and in Velox we use extra filter to get only the rows corresponding to the bucket number requested.
Yuhta
force-pushed
the
tasks/T192188366/0
branch
from
5150948
to
0596214
Compare
xiaoxmeng
approved these changes
Jun 18, 2024
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the bucket count of a table changes over time, there can be legitimate cases that multiple buckets exist in the same file. In such cases the query planner should set bucket conversion for these splits and in Velox we use extra filter to get only the rows corresponding to the bucket number requested.