-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prioritize high confidence stats during broadcast joins #23016
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinavmuk04
force-pushed
the
milestone2p1
branch
9 times, most recently
from
June 24, 2024 19:50
2d8068c
to
e7035e6
Compare
abhinavmuk04
force-pushed
the
milestone2p1
branch
from
June 24, 2024 21:39
e7035e6
to
877577f
Compare
rschlussel
reviewed
Jun 25, 2024
.../main/java/com/facebook/presto/sql/planner/iterative/rule/DetermineJoinDistributionType.java
Outdated
Show resolved
Hide resolved
rschlussel
reviewed
Jun 25, 2024
presto-main/src/main/java/com/facebook/presto/sql/planner/iterative/rule/ReorderJoins.java
Outdated
Show resolved
Hide resolved
.../main/java/com/facebook/presto/sql/planner/iterative/rule/DetermineJoinDistributionType.java
Outdated
Show resolved
Hide resolved
abhinavmuk04
force-pushed
the
milestone2p1
branch
18 times, most recently
from
June 26, 2024 23:00
4ec8d3c
to
3678abb
Compare
abhinavmuk04
force-pushed
the
milestone2p1
branch
2 times, most recently
from
June 27, 2024 19:46
130f853
to
ea33056
Compare
abhinavmuk04
requested review from
jaystarshot,
feilong-liu and
a team
as code owners
June 27, 2024 19:55
abhinavmuk04
force-pushed
the
milestone2p1
branch
from
June 27, 2024 19:55
ea33056
to
cda1c68
Compare
feilong-liu
reviewed
Jun 28, 2024
presto-main/src/main/java/com/facebook/presto/SystemSessionProperties.java
Outdated
Show resolved
Hide resolved
.../main/java/com/facebook/presto/sql/planner/iterative/rule/DetermineJoinDistributionType.java
Outdated
Show resolved
Hide resolved
.../main/java/com/facebook/presto/sql/planner/iterative/rule/DetermineJoinDistributionType.java
Outdated
Show resolved
Hide resolved
.../main/java/com/facebook/presto/sql/planner/iterative/rule/DetermineJoinDistributionType.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/sql/planner/iterative/rule/ReorderJoins.java
Outdated
Show resolved
Hide resolved
.../main/java/com/facebook/presto/sql/planner/iterative/rule/DetermineJoinDistributionType.java
Outdated
Show resolved
Hide resolved
...t/java/com/facebook/presto/sql/planner/iterative/rule/TestDetermineJoinDistributionType.java
Show resolved
Hide resolved
presto-tests/src/test/java/com/facebook/presto/execution/TestHistoryBasedStatsTracking.java
Show resolved
Hide resolved
abhinavmuk04
force-pushed
the
milestone2p1
branch
3 times, most recently
from
June 29, 2024 22:13
14a700a
to
23992de
Compare
feilong-liu
reviewed
Jun 29, 2024
...o-main/src/main/java/com/facebook/presto/sql/planner/iterative/ConfidenceBasedBroadcast.java
Outdated
Show resolved
Hide resolved
.../main/java/com/facebook/presto/sql/planner/iterative/rule/DetermineJoinDistributionType.java
Outdated
Show resolved
Hide resolved
.../main/java/com/facebook/presto/sql/planner/iterative/rule/DetermineJoinDistributionType.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/sql/planner/iterative/rule/ReorderJoins.java
Outdated
Show resolved
Hide resolved
abhinavmuk04
force-pushed
the
milestone2p1
branch
3 times, most recently
from
June 29, 2024 22:59
0d702bb
to
6395dd5
Compare
feilong-liu
reviewed
Jul 1, 2024
...in/src/main/java/com/facebook/presto/sql/planner/iterative/ConfidenceBasedBroadcastUtil.java
Outdated
Show resolved
Hide resolved
feilong-liu
reviewed
Jul 1, 2024
presto-main/src/main/java/com/facebook/presto/sql/planner/iterative/rule/ReorderJoins.java
Outdated
Show resolved
Hide resolved
abhinavmuk04
force-pushed
the
milestone2p1
branch
from
July 1, 2024 19:00
6395dd5
to
5ec99f0
Compare
abhinavmuk04
force-pushed
the
milestone2p1
branch
from
July 1, 2024 19:03
5ec99f0
to
5b4d1bd
Compare
feilong-liu
approved these changes
Jul 1, 2024
Code lgtm. However, as a code owner, I do not have ownership for the SystemSessionProperty file, will need an committer approval for help to merge the change here. |
NikhilCollooru
approved these changes
Jul 1, 2024
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prioritize high confidence stats during broadcast joins if enabled
Motivation and Context
When there are two PlanNodes in which they are both small enough for broadcast join we will prioritize the side which has higher confidence stats. If they both have high confidence stats then we keep the original behavior. The user has the ability to turn this on and off.
Impact
This change will create a feature which the user can utilize to improve optimization and help improve the execution time of broadcast join queries
Test Plan
Implemented various tests in both DetermineJoinDistributionType and ReorderJoinsType, which will check if, with the session property enable, nodes with the higher confidence stats will be broadcasted
Contributor checklist
Release Notes