Add new Serializer interface

prestodb · Jan 31, 2024 · c739d83 · c739d83
1 parent 4d489a4
commit c739d83
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 12 deletions.
diff --git a/presto-native-execution/presto_cpp/main/PeriodicTaskManager.cpp b/presto-native-execution/presto_cpp/main/PeriodicTaskManager.cpp
@@ -284,17 +284,6 @@ void PeriodicTaskManager::updateCacheStats() {
   RECORD_METRIC_VALUE(
       kCounterMemoryCacheSumEvictScore, memoryCacheStats.sumEvictScore);
 
-  if (memoryCacheStats.ssdStats) {
-    RECORD_METRIC_VALUE(
-        kCounterSsdCacheCachedEntries,
-        memoryCacheStats.ssdStats->entriesCached);
-    RECORD_METRIC_VALUE(
-        kCounterSsdCacheCachedRegions,
-        memoryCacheStats.ssdStats->regionsCached);
-    RECORD_METRIC_VALUE(
-        kCounterSsdCacheCachedBytes, memoryCacheStats.ssdStats->bytesCached);
-  }
-
   // Interval cumulatives.
   RECORD_METRIC_VALUE(
       kCounterMemoryCacheNumHit,

diff --git a/presto-native-execution/presto_cpp/main/PrestoMain.cpp b/presto-native-execution/presto_cpp/main/PrestoMain.cpp
@@ -27,7 +27,6 @@ int main(int argc, char* argv[]) {
   google::InstallFailureSignalHandler();
   PRESTO_STARTUP_LOG(INFO) << "Entering main()";
   facebook::presto::PrestoServer presto(FLAGS_etc_dir);
-  facebook::velox::BaseStatsReporter::registered = true;
   presto.run();
   PRESTO_SHUTDOWN_LOG(INFO) << "Exiting main()";
 }
diff --git a/presto-native-execution/presto_cpp/main/PrestoServer.cpp b/presto-native-execution/presto_cpp/main/PrestoServer.cpp
@@ -227,6 +227,10 @@ void PrestoServer::run() {
     exit(EXIT_FAILURE);
   }
 
+  if(systemConfig->enableRuntimeStatsCollection()) {
+    // This flag must be set to register the counters.
+    facebook::velox::BaseStatsReporter::registered = true;
+  }
   registerStatsCounters();
   registerFileSinks();
   registerFileSystems();

diff --git a/presto-native-execution/presto_cpp/main/common/StatsReporterImpl.h b/presto-native-execution/presto_cpp/main/common/StatsReporterImpl.h
@@ -22,6 +22,9 @@
 
 namespace facebook::presto {
 
+class MetricsSerializer {
+  facebook::velox::StringView getMetrics();
+};
 class StatsReporterImpl : public facebook::velox::BaseStatsReporter {
  public:
   StatsReporterImpl(