Skip to content

Commit

Permalink
[native] Minor cosmetic changes.
Browse files Browse the repository at this point in the history
  • Loading branch information
amitkdutta authored and aditi-pandit committed Jul 2, 2024
1 parent 6fe54ea commit 37a9cb3
Showing 1 changed file with 4 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
// clang-format on

#include <folly/String.h>
#include <folly/container/F14Set.h>

#include "presto_cpp/main/operators/BroadcastWrite.h"
#include "presto_cpp/main/operators/PartitionAndSerialize.h"
Expand Down Expand Up @@ -86,7 +85,7 @@ std::string toJsonString(const T& value) {
std::shared_ptr<connector::ColumnHandle> toColumnHandle(
const protocol::ColumnHandle* column,
const TypeParser& typeParser) {
auto& connector = getPrestoToVeloxConnector(column->_type);
const auto& connector = getPrestoToVeloxConnector(column->_type);
return connector.toVeloxColumnHandle(column, typeParser);
}

Expand All @@ -96,7 +95,7 @@ std::shared_ptr<connector::ConnectorTableHandle> toConnectorTableHandle(
const TypeParser& typeParser,
std::unordered_map<std::string, std::shared_ptr<connector::ColumnHandle>>&
assignments) {
auto& connector =
const auto& connector =
getPrestoToVeloxConnector(tableHandle.connectorHandle->_type);
return connector.toVeloxTableHandle(
tableHandle, exprConverter, typeParser, assignments);
Expand Down Expand Up @@ -231,7 +230,7 @@ std::vector<core::FieldAccessTypedExprPtr> toFieldExprs(
const VeloxExprConverter& exprConverter) {
std::vector<core::FieldAccessTypedExprPtr> fields;
fields.reserve(expressions.size());
for (auto& expr : expressions) {
for (const auto& expr : expressions) {
auto field = std::dynamic_pointer_cast<const core::FieldAccessTypedExpr>(
exprConverter.toVeloxExpr(expr));
VELOX_CHECK_NOT_NULL(
Expand All @@ -248,7 +247,7 @@ std::vector<core::TypedExprPtr> toTypedExprs(
const VeloxExprConverter& exprConverter) {
std::vector<core::TypedExprPtr> typedExprs;
typedExprs.reserve(expressions.size());
for (auto& expr : expressions) {
for (const auto& expr : expressions) {
auto typedExpr = exprConverter.toVeloxExpr(expr);
auto field =
std::dynamic_pointer_cast<const core::FieldAccessTypedExpr>(typedExpr);
Expand Down

0 comments on commit 37a9cb3

Please sign in to comment.