-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] - v4-alpha.1 #502
Closed
Closed
[WIP] - v4-alpha.1 #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1e3c9e4
to
15e65c7
Compare
7 tasks
The year is 2047, and every Go function in existence takes a context.
Closing in favor of #507 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #484, all commits have been squashed from that branch.
There will be a separate place to capture all the additions, changes, removals and fixes.
The goal of these alpha branches is to continue polishing up the PR, making sure the package is idiomatic, has good test coverage and supports the main features. There will be breaking changes along the alpha branches, less in the beta, and little in the release candidates.
Here's the current plan for rollout:
alpha.N
goose_test.go
from the /v3 modulet.TempDir()
instead of building to the local filesystemgoose init
commandctx
to the Go register functions such as GoMigration and GoMigrationNoTxbeta.N
*goose.Provider
(maybe?)-certfile
,-ssl-cert
, and-ssl-key
rc.N (release candidate)
goose validate
commandRationale
I think it makes sense to break the register functions and force the user to write context-aware functions. It's become a standard in the Go community to pass down the context for request-scoped values, cancelation signals, and deadlines.
In this case, goose may receive a termination signal and it should be possible for the registered Go function to respect this signal and gracefully handle it.