[/v4] - checkpoint 2 #492
Merged
[/v4] - checkpoint 2 #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added an improved
Fiximplementation with additional tests.Also added back the lazy parsing of SQL files, but we do this before applying any migrations so that we can fail fast if there are any errors and avoid leaving the database in a partially migrated state.
This is done to avoid parsing the SQL migration if it is never needed (e.g. the user is running a Go migration). Also, the majority of the time migrations are incremental, so it is likely that the user will only want to run the last few migrations, and there is no need to parse ALL previous migrations.