Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mathjax footnotes moved to buckram #1268

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

arzola
Copy link
Contributor

@arzola arzola commented Oct 7, 2024

Buckram styles needs to be included in buckram in order to avoid chocking the SCSS parser and have this working on all of pb themes

@arzola arzola changed the title fix: mathjax moved to buckram fix: mathjax footnotes moved to buckram Oct 7, 2024
Copy link
Contributor

@ho-man-chan ho-man-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ho-man-chan ho-man-chan merged commit b89b6de into dev Oct 7, 2024
5 checks passed
@ho-man-chan ho-man-chan deleted the chore/bump-buckram branch October 7, 2024 20:51
Copy link

sentry-io bot commented Oct 7, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ReferenceError: jQuery is not defined 761(app/themes/pressbooks-book/dist/scripts/book) View Issue
  • ‼️ TypeError: jQuery is not a function 761(app/themes/pressbooks-book/dist/scripts/book) View Issue
  • ‼️ SyntaxError: Failed to execute 'querySelector' on 'Document': '#4l2p2' is not a valid selector. Object.init(app/themes/pressbooks-book/dist/scr... View Issue
  • ‼️ ReferenceError: jQuery is not defined Object.761(app/themes/pressbooks-book/dist/scri... View Issue
  • ‼️ SyntaxError: The string did not match the expected pattern. init(app/themes/pressbooks-book/dist/scripts/book) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants