Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control subsection #583

Closed
wants to merge 9 commits into from
Closed

Control subsection #583

wants to merge 9 commits into from

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Jul 19, 2023

SUMMARY

Recent design proposals point towards removing the uppercase usage
across the board, and this PR starts the process with form labels.

it builds upon apache#24736 that
started to address hierarchy-is-unclear issue in Explore control panel
and makes things a bit neater on top of it.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

after

Screen Shot 2023-07-19 at 3 14 10 PM

before

Screen Shot 2023-07-19 at 3 04 59 PM

@mistercrunch
Copy link
Member Author

Other forms affected ->
Screen Shot 2023-07-19 at 3 20 21 PM
Screen Shot 2023-07-19 at 3 20 13 PM
Screen Shot 2023-07-19 at 3 20 08 PM
Screen Shot 2023-07-19 at 3 21 10 PM

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2023

Codecov Report

Patch coverage: 25.00% and project coverage change: +0.01 🎉

Comparison is base (7675e0d) 68.94% compared to head (cc84ee1) 68.96%.

❗ Current head cc84ee1 differs from pull request most recent head 494b9e8. Consider uploading reports for the commit 494b9e8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #583      +/-   ##
==========================================
+ Coverage   68.94%   68.96%   +0.01%     
==========================================
  Files        1901     1902       +1     
  Lines       73898    73902       +4     
  Branches     8175     8175              
==========================================
+ Hits        50951    50966      +15     
+ Misses      20834    20817      -17     
- Partials     2113     2119       +6     
Flag Coverage Δ
javascript 55.80% <25.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/packages/superset-ui-chart-controls/src/index.ts 100.00% <ø> (ø)
...-chart-controls/src/sections/advancedAnalytics.tsx 14.28% <ø> (ø)
...rset-ui-chart-controls/src/sections/chartTitle.tsx 100.00% <ø> (ø)
...legacy-plugin-chart-partition/src/controlPanel.tsx 25.00% <ø> (ø)
...gins/legacy-plugin-chart-rose/src/controlPanel.tsx 50.00% <ø> (ø)
...gins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx 100.00% <ø> (ø)
.../BigNumber/BigNumberWithTrendline/controlPanel.tsx 16.66% <ø> (ø)
...s/plugin-chart-echarts/src/Funnel/controlPanel.tsx 66.66% <ø> (ø)
...ns/plugin-chart-echarts/src/Gauge/controlPanel.tsx 66.66% <ø> (ø)
...ns/plugin-chart-echarts/src/Graph/controlPanel.tsx 21.42% <ø> (ø)
... and 15 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants