feat: support opendistro #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
==========================================
+ Coverage 89.41% 93.53% +4.12%
==========================================
Files 15 15
Lines 633 681 +48
==========================================
+ Hits 566 637 +71
+ Misses 67 44 -23
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
villebro
reviewed
Jan 20, 2021
| @@ -120,19 +177,19 @@ def __init__(self, url, es, **kwargs): | |||
| # this is set to an iterator after a successfull query | |||
| self._results = None | |||
|
|
|||
| @property | |||
| @property # type: ignore | |||
There was a problem hiding this comment.
what was the complaint here?
There was a problem hiding this comment.
es/baseapi.py:189: error: Decorated property not supported
python/mypy#1362 with a bunch of comments from the creator himself ;)
There was a problem hiding this comment.
Oh wow, quite the can of worms
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
…dbapi into feat/opendistro
willbarrett
reviewed
Jan 20, 2021
|
Thank you @villebro and @willbarrett for taking the time to review |
villebro
approved these changes
Jan 21, 2021
| @@ -120,19 +177,19 @@ def __init__(self, url, es, **kwargs): | |||
| # this is set to an iterator after a successfull query | |||
| self._results = None | |||
|
|
|||
| @property | |||
| @property # type: ignore | |||
There was a problem hiding this comment.
Oh wow, quite the can of worms
es/basesqlalchemy.py
Outdated
| return "DATETIME" | ||
|
|
||
| def visit_TIME(self, type_, **kwargs): | ||
| def visit_TIME(self, type_, **kwargs: Dict[str, Any]) -> str: |
es/basesqlalchemy.py
Outdated
| raise exceptions.NotSupportedError("Type TIME is not supported") | ||
|
|
||
| def visit_BINARY(self, type_, **kwargs): | ||
| def visit_BINARY(self, type_, **kwargs: Dict[str, Any]) -> str: |
es/basesqlalchemy.py
Outdated
| raise exceptions.NotSupportedError("Type BINARY is not supported") | ||
|
|
||
| def visit_VARBINARY(self, type_, **kwargs): | ||
| def visit_VARBINARY(self, type_, **kwargs: Dict[str, Any]) -> str: |
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
…dbapi into feat/opendistro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides support for Opendistro Elasticsearch https://opendistro.github.io/for-elasticsearch-docs/
Still pending some issues:
_mappingendpointSELECT 1is caught and then issues an Elasticsearch.ping()Also adds
mypycheckCloses: #31 #5 #7 #6