Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1.0.3 (#24) #25

Closed
wants to merge 2 commits into from
Closed

V1.0.3 (#24) #25

wants to merge 2 commits into from

Conversation

oriolsr
Copy link

@oriolsr oriolsr commented Nov 17, 2016

material-ui#21
react-tap-event-plugin#82

Below dependencies should be updated
material-ui@0.16.3
react-tap-event-plugin@2.0.0

@oriolsr oriolsr changed the title V1.0.3 #24 V1.0.3 (#24) Nov 17, 2016
@prescottprue
Copy link
Owner

prescottprue commented Nov 18, 2016

Saw the following

Warning

  • contextType to div (seems to relate to material-ui)
    screen shot 2016-11-17 at 9 36 58 pm

Errors

screenshot 2016-11-18 01 16 03

It seems like this might also involves updating react and react-dom both to ^15.4.0. Let me keep testing a bit, and this will most likely make it into the v1.0.4 (there are other small changes that need to make it into v1.0.3).

@prescottprue
Copy link
Owner

prescottprue commented Nov 18, 2016

v1.0.3 was released with the version of react-tap-event-plugin locked to v1.0.0 while react and react-dom are locked to v15.3.2.

Hoping to get a completely working version with everything updated, but it is important to keep everything stable. Please feel free to make another PR for v1.0.4 or onward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants