Skip to content
This repository has been archived by the owner on Dec 6, 2023. It is now read-only.

fix: redis script bug unbound variable #138

Merged
merged 1 commit into from
Nov 3, 2023
Merged

fix: redis script bug unbound variable #138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion vec-redis/setup-redis.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ MODULEDIR="$tmpdir/lib"
--protected-mode no \
--daemonize no \
--loadmodule "${MODULEDIR}/redisearch.so" ${REDISEARCH_ARGS} \
--loadmodule "${MODULEDIR}/redisgears.so" v8-plugin-path "${MODULEDIR}/libredisgears_v8_plugin.so" ${REDISGEARS_ARGS} \
"$@") &
Copy link
Contributor

@casperdcl casperdcl Nov 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure you can't do this instead?

Suggested change
"$@") &
--loadmodule "${MODULEDIR}/redisgears.so" v8-plugin-path "${MODULEDIR}/libredisgears_v8_plugin.so" \
"$@") &

actually also is it still safe to put "$@" here? how does --loadmodule know which args are for the module and which are for redis-stack?

Are they all magically handled https://stackoverflow.com/q/55078246?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we don't need redisgears for vector db only redisearch is needed, and --loadmodule seems to take only the required arguments (from whatever I've tested locally) and all other arguments are passed down to redis-server hence setup-redis.sh --port 8001 works


wait
Loading